User data file storage #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch to csv - validate index combinations in uploaded data - remove uploaded file when applied
validate numeric values make error message disappeare after three seconds
also adjust "edit input data" help text
markushal
requested changes
Dec 5, 2023
There was a problem hiding this comment.
That look great, UI and functionality as well as validation and tests! One small issue:
When uploading a csv file with wrong column name, this triggers an error message and the file is not uploaded (which is nice). But the app performs a rerun immediately after, which clears the error message as soon as the rerun has been performed. Can you implement an ok button that needs to be clicked to make the error message go away?
markushal
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a first draft for user data retrieval from file
open Tasks:
resolves #71