Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove infobox and add option switch between tabs programatically #159

Merged
merged 4 commits into from
Dec 7, 2023
Merged

remove infobox and add option switch between tabs programatically #159

merged 4 commits into from
Dec 7, 2023

Conversation

joAschauer
Copy link
Collaborator

resolves #157
this introduces a new dependency streamlit-antd-components

@joAschauer joAschauer requested a review from markushal December 6, 2023 14:09
markushal
markushal approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@markushal markushal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine for me. I would have preferred not to use custom components at all, but the impact on the code base is quite small it would not be too difficult to switch back to the old tabs system if we need to.

@markushal markushal merged commit 51694e2 into develop Dec 7, 2023
3 checks passed
@wingechr wingechr deleted the antd_tabs branch April 29, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushal markushal markushal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove demand country infobox in dashboard and link to country fact sheets tab
2 participants
@joAschauer @markushal