Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element grouping with bordered containers #165

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

joAschauer
Copy link
Collaborator

bundled a few parts in functions, this makes potential future merge conflicts less likely.
also removed columns in sustainability tab and added a Title to the references List.

resolves #156

@joAschauer joAschauer requested a review from markushal December 7, 2023 15:47
Copy link
Collaborator

@markushal markushal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the borders do a good job of structuring the content. Just one question: In the sustainability tab, the explanatory text is now below the figure and not next to it like before. Was that intentional? I think it is OK like that, but then we would need to make some changes to the text (see figure)

grafik

I will approve and merge the PR regardless of how we proceed with this issue to quickly move the code changes to develop, and to prevent future merge conflicts.

@markushal markushal merged commit 0426fa6 into develop Dec 8, 2023
3 checks passed
@markushal markushal deleted the bordered_containers branch December 8, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group thematic related elements in boxes
2 participants