188 compare results with and without user changes #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joAschauer
requested changes
Dec 13, 2023
Co-authored-by: Johannes Aschauer <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Johannes Aschauer <[email protected]>
Co-authored-by: Johannes Aschauer <[email protected]>
for more information, see https://pre-commit.ci
|
@joAschauer I applied your suggestions but kept the column layout like it is. For now. |
joAschauer
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joAschauer please have a look at this. I implemented a way to compare costs with and without considering user data changes. I find this very helpful in understanding the effects of modifying input data.
I am sure the implementation and representation of the data can still be improved...