Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

316 prevent storage between weeks #323

Merged
merged 15 commits into from
Apr 17, 2024
Merged

Conversation

markushal
Copy link
Collaborator

No description provided.

@markushal markushal linked an issue Apr 16, 2024 that may be closed by this pull request
@markushal markushal requested a review from wingechr April 16, 2024 15:12
@markushal
Copy link
Collaborator Author

@wingechr

  • I did some modifications to the optimize function to prevent storing energy between weeks
  • I did a rewrite of the optimization tab
  • All tests pass except for one I marked as expected to fail, it has outdated expected values, but I did not understand how to change them

@markushal markushal marked this pull request as ready for review April 16, 2024 15:15
@wingechr
Copy link
Collaborator

yea, the tests that expect specific values as results are not very useful as long as the calculations/optimizations are not stable.
we can leave them as xfail for now

@wingechr wingechr merged commit d321d2a into develop Apr 17, 2024
3 checks passed
@wingechr wingechr deleted the 316-prevent-storage-between-weeks branch April 19, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prevent storage between weeks
2 participants