Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally consider user data in optimization #382

Merged
merged 7 commits into from
May 16, 2024
Merged

Optionally consider user data in optimization #382

merged 7 commits into from
May 16, 2024

Conversation

joAschauer
Copy link
Collaborator

No description provided.

@wingechr wingechr marked this pull request as ready for review May 15, 2024 16:55
markushal
markushal requested changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@markushal markushal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example:

  • I use Methane (AEL) as process chain.
  • I change AEL electrolyzer CAPEX
  • Good: This triggers one, and only one optimization call
  • Not so good: the electrolyzer CAPEX in the optimization tab (and the results of the optimization) do not change.

grafik

@joAschauer
Copy link
Collaborator Author

Example:

* I use Methane (AEL) as process chain.

* I change AEL electrolyzer CAPEX

* Good: This triggers one, and only one optimization call

* Not so good: the electrolyzer CAPEX in the optimization tab (and the results of the optimization) do not change.

Because the changes are not considered in api.get_flh_opt_network. @wingechr should I do that?

@wingechr
Copy link
Collaborator

@joAschauer sure.

@joAschauer joAschauer requested a review from markushal May 16, 2024 09:01
markushal
markushal approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@markushal markushal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@markushal markushal merged commit 9a0a869 into develop May 16, 2024
3 checks passed
@markushal markushal deleted the api-optimize-user-data-optional branch May 16, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushal markushal markushal approved these changes

Assignees

@wingechr wingechr

@joAschauer joAschauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joAschauer @wingechr @markushal