Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename interest rate to "WACC" #428

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

joAschauer
Copy link
Collaborator

Fixes #223

@joAschauer joAschauer requested a review from markushal June 6, 2024 11:42
Copy link
Collaborator

@markushal markushal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

choosing "WACC" in the input data tab raises an exception:

grafik

@wingechr
Copy link
Collaborator

wingechr commented Jun 7, 2024

@markushal I don't have this error

@joAschauer
Copy link
Collaborator Author

choosing "WACC" in the input data tab raises an exception:

also cannot reproduce

@wingechr
Copy link
Collaborator

I think we should merge it and then check locally with @markushal

@markushal
Copy link
Collaborator

Hmmm. That is weird. I just tried again, and I also cant reproduce the error. Then lets merge it.

@markushal markushal merged commit 03a1141 into develop Jun 10, 2024
3 checks passed
@wingechr wingechr deleted the joAschauer/223-rename-interest-rate-to-WACC branch June 21, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename interest rate to "WACC"
3 participants