564 differences between costs in optimization tab and costs tab #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces-between-costs-in-optimization-tab-and-costs-tab
|
this is an overview of cost differences from the test:
|
Fixes #553
markushal
commented
Sep 16, 2024
There was a problem hiding this comment.
@wingechr now it looks much better. If you could adress the electricity cost / FLOW cost issue, the remaining differences are small enough that I can live with them.
Could you do this, and make the test pass? e.g. by relaxing the tolerance for the differences test
| flh_opt_function = res_optimize["DERIV"]["FLH"] * 8760 | ||
| assert flh_opt_tab == pytest.approx(flh_opt_function) | ||
|
|
||
| # assert that differences between costs and opt tab are zero: |
There was a problem hiding this comment.
@wingechr electricity specific costs are >0! They must be zero, and el. consumption must not create FLOW costs
Comment on lines
+55
to
+58
| # storage efficiency must not affect main chain scaling factors: | ||
| if process_code not in ["EL-STR", "H2-STR"]: | ||
| main_input_value = main_output_value | ||
| main_output_value = main_input_value * eff |
There was a problem hiding this comment.
@wingechr this was the reason for higher RES capacities in the api.
wingechr
reviewed
Sep 17, 2024
| # and this should have zero specific cost | ||
| assert res_costs_agg.at["Derivative production", "FLOW"] == 0 | ||
| assert input_data.loc["SPECCOST,,EL,,", "value"] == 0 | ||
|
|
There was a problem hiding this comment.
@markushal SPECCOST in input data can be > 0, for post transport processes
wingechr
deleted the
564-differences-between-costs-in-optimization-tab-and-costs-tab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.