Api calculate #11 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 21, 2023
joAschauer
changed the title
This was referenced Nov 21, 2023
joAschauer
approved these changes
Nov 21, 2023
Comment on lines
37
to
41
| class PtxCalc: | ||
| def __init__( | ||
| self, | ||
| data_handler, | ||
| ): | ||
| def __init__(self, data_handler: DataHandler): | ||
| self.data_handler = data_handler | ||
|
|
||
| def calculate( |
There was a problem hiding this comment.
we could get rid of the class here and just pass data_handler to a function calculate.
Comment on lines
37
to
41
| class PtxCalc: | ||
| def __init__( | ||
| self, | ||
| data_handler, | ||
| ): | ||
| def __init__(self, data_handler: DataHandler): | ||
| self.data_handler = data_handler | ||
|
|
||
| def calculate( |
There was a problem hiding this comment.
This is a long function. Can calculate be refactored to smaller functions? might be worth it if we need to touch it in the future again, otherwise let's keep it this way.
There was a problem hiding this comment.
yes,I want to go back to a class based implementation now that it works
yea, thanks! I am not used to pytest yet. Co-authored-by: Johannes Aschauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.