Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource step with explicit scopes #785

Merged
merged 1 commit into from
Jul 5, 2023
Merged

New resource step with explicit scopes #785

merged 1 commit into from
Jul 5, 2023

Conversation

agourlay
Copy link
Owner

@agourlay agourlay commented Jul 2, 2023

Tackles #237

This PR introduces a new abstraction for resource steps which are released at the end of a wrapping scope.

See integration test for example.

@agourlay agourlay requested a review from yanns July 2, 2023 12:26
Copy link
Collaborator

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@agourlay
Copy link
Owner Author

agourlay commented Jul 5, 2023

Thanks for the review!

I will merge as it is and release a new version to gather user feedback.

Afterward we could iterate on a way to compose Resources as described in the original issue.

@agourlay agourlay merged commit 8a2932f into master Jul 5, 2023
@agourlay agourlay deleted the resource-step branch July 5, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants