Autoscroll tablature during while playing #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VladasZ Could you maybe give this branch a try and tell me how it goes for you :) |
agourlay
commented
Aug 31, 2024
| let canvas = Canvas::new(self) | ||
| .height(vertical_measure_height + FIRST_STRING_Y * 2.0) | ||
| .height(self.vertical_measure_height) |
There was a problem hiding this comment.
avoid recomputing the constant for each redraw
|
Hi! I tried it and the scroll does work. A small thing that bothers me is that it scrolls after each line. In comparison guitar pro scrolls only at the end of the page and in my opinion it is easier to read with such scroll. But still this implementation is much better than no scroll at all and it should be merged and maybe improved later. Also I found a bug while testing: #11 |
|
Thanks a lot for the feedback! I was able to fix #11
Also agree with you there 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackling #7
The implementation is slightly hacky but seems to get the job done.
Looking forward to get feedback on the resulting scroll :)