handle cpal errors before starting playback #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Investigate audio buffer sizing
this is a quick fix that was added because i don't use a desktop environment on linux, and wasn't able get the file picker to appear, despite having installed several xdg-desktop-portal-* packages
cpal's device.default_output_config() may panic in edge cases, e.g. when using USB speakers. if this happens, playback should not be started.
|
Thanks for the contribution 👍
Also this PR contains also your change with passing the file name to the CLI. |
agourlay
merged commit 943756e
into
agourlay:investigate-audio-buffer-sizing
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpal'sDevice::default_output_config()may panic in edge cases, e.g. when using USB speakers. if this happens, playback should not be started.A possibly relevant upstream issue (from 2022): RustAudio/cpal#680
Fixes #14