fix deadlock with single worker

agourlay · Aug 21, 2022 · 2077cc5 · 2077cc5
1 parent decd6c6
commit 2077cc5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/src/password_finder.rs b/src/password_finder.rs
@@ -230,12 +230,11 @@ mod tests {
         assert!(password.is_none());
     }
 
-    // Takes too long on the CI
-    //#[test]
-    // fn find_four_letters_password() {
-    //     let password = find_password_gen("test-files/4.test.txt.zip", 4)
-    //         .unwrap()
-    //         .unwrap();
-    //     assert_eq!(password, "abcd");
-    // }
+    #[test]
+    fn find_four_letters_password() {
+        let password = find_password_gen("test-files/4.test.txt.zip", 4)
+            .unwrap()
+            .unwrap();
+        assert_eq!(password, "abcd");
+    }
 }
diff --git a/src/password_worker.rs b/src/password_worker.rs
@@ -39,10 +39,10 @@ pub fn password_checker(
                                 match zip.read_to_end(&mut buffer) {
                                     Err(_) => (), // password collision - continue
                                     Ok(_) => {
+                                        // Send password and continue processing while waiting for signal
                                         send_password_found
                                             .send(password)
                                             .expect("Send found password should not fail");
-                                        break;
                                     }
                                 }
                             }