Bump rubocop from 1.69.2 to 1.70.0 #202

dependabot · 2025-01-13T22:13:42Z

Bumps rubocop from 1.69.2 to 1.70.0.

Release notes

RuboCop 1.70

New features

#13474: Add new Style/ItAssignment cop to detect local assignments to it inside blocks. ([@dvandersluis][])

#11013: Add new Lint/SharedMutableDefault cop to alert on mutable Hash defaults. ([@corsonknowles][])

#13612: Create new cop Lint/ConstantReassignment. ([@lovro-bikic][])

#13628: Make LSP server support quick fix code action. ([@koic][])

#13607: Support passing the target ruby version through an environment variable. ([@elliottt][])

#13628: Add support for Ruby LSP as a built-in add-on. ([@koic][])

#13284: Add new target_gem_version API to change behavior of a cop at runtime depending on which gem version is present. ([@earlopain][])

Bug fixes

#13589: Fix Lint/NonAtomicFileOperation to detect offenses with fully qualified constants. ([@viralpraxis][])

#13630: Fix CLI --format option to accept fully qualified formatter class names. ([@viralpraxis][])

#13624: Don't show warnings from Lint/Syntax when a syntax error occurs. ([@earlopain][])

#13605: Fix RuboCop::Cop::Util.to_string_literal to work correctly with frozen strings. ([@viralpraxis][])

#12393: Fix false negatives for Lint/Void inside of non-modifier conditionals. ([@GabeIsman][])

#13623: Fix false negatives for Style/MultipleComparison when setting AllowMethodComparison: false and comparing with simple method calls. ([@koic][])

#13644: Fix a false positive for Layout/EmptyLinesAroundAccessModifier when an access modifier and an expression are on the same line. ([@koic][])

#13645: Fix a false positive for Style/MethodCallWithArgsParentheses when setting EnforcedStyle: omit_parentheses and last argument is an endless range. ([@earlopain][])

#13614: Fix false positives for Style/RaiseArgs with anonymous splat and triple dot forwarding. ([@earlopain][])

#13591: Fix false positives for Lint/NestedMethodDefinition when defining a method on a constant or a method call. ([@koic][])

#13594: Fix false positives for Style/MultipleComparison when using multiple safe navigation method calls. ([@koic][])

#13654: Fix false positives for Style/RedundantInitialize when empty initialize method has arguments. ([@marocchino][])

#13608: Fix crash when running rubocop -d on a config with a remote inherit_from that causes a duplicate setting warning. ([@dvandersluis][])

#12430: Fix false negatives in Style/RedundantLineContinuation with multiple line continuations. ([@dvandersluis][])

#13638: Fix false positive for Naming/BlockForwarding when method just returns the block argument. ([@mvz][])

#13599: Fix incorrect autocorrect for Layout/HashAlignment when there is a multiline positional argument and Layout/ArgumentAlignment is configured with EnforcedStyle: with_fixed_indentation. ([@dvandersluis][])

#13586: Fix regression in Layout/SpaceAroundOperators when different comparison operators were aligned with each other. ([@dvandersluis][])

#13603: Fix Lint/LiteralInInterpolation cop error on invalid string literal. ([@viralpraxis][])

#13582: Fix Lint/NonAtomicFileOperation cop error on non-constant receiver. ([@viralpraxis][])

#13598: Fix Lint/Void cop error on if without body. ([@viralpraxis][])

#13634: Fix Style/ClassAndModuleChildren cop error on compact enforced style and unindented body. ([@viralpraxis][])

#13642: Fix Style/FloatDivision cop error if #to_f has implicit receiver. ([@viralpraxis][])

#13517: Fixes Style/HashExcept to recognize safe navigation when ActiveSupportExtensionsEnabled config is enabled. ([@lovro-bikic][])

#13585: Fix Style/HashSyntax cop error on implicit call method. ([@viralpraxis][])

#13632: Fix Style/MissingElse cop error if Style/EmptyElse's EnforcedStyle is not both and if expression contains elsif. ([@viralpraxis][])

#13659: Fix Style/MissingElse cop error if Style/EmptyElse's EnforcedStyle is not both and if expression contains multiple elsif. ([@viralpraxis][])

#13596: Fix Style/RedundantCondition cop error on parentheses and modifier if in else. ([@viralpraxis][])

#13616: Fix incorrect autocorrect for Style/RedundantRegexpArgument when the regex contains a single quote. ([@mrzasa][])

#13619: Fix Style/YodaExpression cop error in case of suffix form of operator. ([@viralpraxis][])

#13578: Update Layout/LineContinuationSpacing to ignore continuations inside a regexp or xstr. ([@dvandersluis][])

#13601: Update Style/SuperArguments to handle super with a block or with a chained method with a block. ([@dvandersluis][])

#13568: Fix NoMethodError in ConfigValidator when a Cop's config is not a Hash and raise ValidationError instead. ([@amomchilov][])

Changes

#13665: Add support for safe navigation to Style/ObjectThen. ([@dvandersluis][])

#13657: Add support for safe navigation to Layout/HashAlignment. ([@dvandersluis][])

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.70.0 (2025-01-10)

New features

#13474: Add new Style/ItAssignment cop to detect local assignments to it inside blocks. ([@dvandersluis][])

#11013: Add new Lint/SharedMutableDefault cop to alert on mutable Hash defaults. ([@corsonknowles][])

#13612: Create new cop Lint/ConstantReassignment. ([@lovro-bikic][])

#13628: Make LSP server support quick fix code action. ([@koic][])

#13607: Support passing the target ruby version through an environment variable. ([@elliottt][])

#13628: Add support for Ruby LSP as a built-in add-on. ([@koic][])

#13284: Add new target_gem_version API to change behavior of a cop at runtime depending on which gem version is present. ([@earlopain][])

Bug fixes

#13589: Fix Lint/NonAtomicFileOperation to detect offenses with fully qualified constants. ([@viralpraxis][])

#13630: Fix CLI --format option to accept fully qualified formatter class names. ([@viralpraxis][])

#13624: Don't show warnings from Lint/Syntax when a syntax error occurs. ([@earlopain][])

#13605: Fix RuboCop::Cop::Util.to_string_literal to work correctly with frozen strings. ([@viralpraxis][])

#12393: Fix false negatives for Lint/Void inside of non-modifier conditionals. ([@GabeIsman][])

#13623: Fix false negatives for Style/MultipleComparison when setting AllowMethodComparison: false and comparing with simple method calls. ([@koic][])

#13644: Fix a false positive for Layout/EmptyLinesAroundAccessModifier when an access modifier and an expression are on the same line. ([@koic][])

#13645: Fix a false positive for Style/MethodCallWithArgsParentheses when setting EnforcedStyle: omit_parentheses and last argument is an endless range. ([@earlopain][])

#13614: Fix false positives for Style/RaiseArgs with anonymous splat and triple dot forwarding. ([@earlopain][])

#13591: Fix false positives for Lint/NestedMethodDefinition when defining a method on a constant or a method call. ([@koic][])

#13594: Fix false positives for Style/MultipleComparison when using multiple safe navigation method calls. ([@koic][])

#13654: Fix false positives for Style/RedundantInitialize when empty initialize method has arguments. ([@marocchino][])

#13608: Fix crash when running rubocop -d on a config with a remote inherit_from that causes a duplicate setting warning. ([@dvandersluis][])

#12430: Fix false negatives in Style/RedundantLineContinuation with multiple line continuations. ([@dvandersluis][])

#13638: Fix false positive for Naming/BlockForwarding when method just returns the block argument. ([@mvz][])

#13599: Fix incorrect autocorrect for Layout/HashAlignment when there is a multiline positional argument and Layout/ArgumentAlignment is configured with EnforcedStyle: with_fixed_indentation. ([@dvandersluis][])

#13586: Fix regression in Layout/SpaceAroundOperators when different comparison operators were aligned with each other. ([@dvandersluis][])

#13603: Fix Lint/LiteralInInterpolation cop error on invalid string literal. ([@viralpraxis][])

#13582: Fix Lint/NonAtomicFileOperation cop error on non-constant receiver. ([@viralpraxis][])

#13598: Fix Lint/Void cop error on if without body. ([@viralpraxis][])

#13634: Fix Style/ClassAndModuleChildren cop error on compact enforced style and unindented body. ([@viralpraxis][])

#13642: Fix Style/FloatDivision cop error if #to_f has implicit receiver. ([@viralpraxis][])

#13517: Fixes Style/HashExcept to recognize safe navigation when ActiveSupportExtensionsEnabled config is enabled. ([@lovro-bikic][])

#13585: Fix Style/HashSyntax cop error on implicit call method. ([@viralpraxis][])

#13632: Fix Style/MissingElse cop error if Style/EmptyElse's EnforcedStyle is not both and if expression contains elsif. ([@viralpraxis][])

#13659: Fix Style/MissingElse cop error if Style/EmptyElse's EnforcedStyle is not both and if expression contains multiple elsif. ([@viralpraxis][])

#13596: Fix Style/RedundantCondition cop error on parentheses and modifier if in else. ([@viralpraxis][])

#13616: Fix incorrect autocorrect for Style/RedundantRegexpArgument when the regex contains a single quote. ([@mrzasa][])

#13619: Fix Style/YodaExpression cop error in case of suffix form of operator. ([@viralpraxis][])

#13578: Update Layout/LineContinuationSpacing to ignore continuations inside a regexp or xstr. ([@dvandersluis][])

#13601: Update Style/SuperArguments to handle super with a block or with a chained method with a block. ([@dvandersluis][])

#13568: Fix NoMethodError in ConfigValidator when a Cop's config is not a Hash and raise ValidationError instead. ([@amomchilov][])

Changes

#13665: Add support for safe navigation to Style/ObjectThen. ([@dvandersluis][])

... (truncated)

Commits

e2f2d5c Cut 1.70
3994f94 Update Changelog
3123800 Dont show parser warnings in Lint/Syntax
9eaedd0 Add Lint/ConstantReassignment cop
4981738 Fix to recognize safe navigation when config is enabled
6f066b8 Fix build errors related to the RubyLSP add-on specs
45cd66a [Fix #13601] Update Style/SuperArguments to handle super with a block or ...
2bfe0f7 Update Style/SuperArguments to handle super with a block or with a chaine...
5d2be60 Update Style/SuperArguments to handle super with a block
e3bcc67 Add range formatting method to the formatter add-on
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Update Rubocop to version 1.70.0.

New Features:

Add new Style/ItAssignment cop to detect local assignments to it inside blocks.
Add new Lint/SharedMutableDefault cop to alert on mutable Hash defaults.
Add new Lint/ConstantReassignment cop.
Add support for Ruby LSP as a built-in add-on.
Make LSP server support quick fix code action.
Support passing the target ruby version through an environment variable.
Add new target_gem_version API to change behavior of a cop at runtime depending on which gem version is present.

Tests:

Fix false negatives for Lint/Void inside of non-modifier conditionals.
Fix false negatives for Style/MultipleComparison when setting AllowMethodComparison: false and comparing with simple method calls.
Fix a false positive for Layout/EmptyLinesAroundAccessModifier when an access modifier and an expression are on the same line.
Fix a false positive for Style/MethodCallWithArgsParentheses when setting EnforcedStyle: omit_parentheses and last argument is an endless range.
Fix false positives for Style/RaiseArgs with anonymous splat and triple dot forwarding.
Fix false positives for Lint/NestedMethodDefinition when defining a method on a constant or a method call.
Fix false positives for Style/MultipleComparison when using multiple safe navigation method calls.
Fix false positives for Style/RedundantInitialize when empty initialize method has arguments.

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.69.2 to 1.70.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.69.2...v1.70.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

sourcery-ai · 2025-01-13T22:13:53Z

Reviewer's Guide by Sourcery

This PR bumps the rubocop gem from 1.69.2 to 1.70.0. This includes several new features, bug fixes, changes, and new cops.

Class diagram showing new RuboCop cops in v1.70.0

classDiagram
    class Style_ItAssignment {
      +detect_local_it_assignments()
    }
    class Lint_SharedMutableDefault {
      +detect_mutable_hash_defaults()
    }
    class Lint_ConstantReassignment {
      +detect_constant_reassignments()
    }

    RuboCop <|-- Style_ItAssignment
    RuboCop <|-- Lint_SharedMutableDefault
    RuboCop <|-- Lint_ConstantReassignment

    note for Style_ItAssignment "New cop to detect local assignments to 'it' inside blocks"
    note for Lint_SharedMutableDefault "New cop to alert on mutable Hash defaults"
    note for Lint_ConstantReassignment "New cop to detect constant reassignments"

File-Level Changes

Change	Details	Files
Bumps the version of rubocop	Updated the rubocop gem dependency from ~> 1.69 to ~> 1.70 in the Gemfile. Regenerated the Gemfile.lock to reflect the updated dependency and resolve any version conflicts.	`Gemfile` `Gemfile.lock`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time. You can also use
this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!

dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jan 13, 2025

sourcery-ai bot reviewed Jan 13, 2025

View reviewed changes

armins approved these changes Jan 16, 2025

View reviewed changes

armins merged commit b3b288e into main Jan 16, 2025
3 checks passed

dependabot bot deleted the dependabot/bundler/rubocop-1.70.0 branch January 16, 2025 11:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump rubocop from 1.69.2 to 1.70.0 #202

Bump rubocop from 1.69.2 to 1.70.0 #202

dependabot bot commented on behalf of github Jan 13, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 13, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

Bump rubocop from 1.69.2 to 1.70.0 #202

Bump rubocop from 1.69.2 to 1.70.0 #202

Conversation

dependabot bot commented on behalf of github Jan 13, 2025 • edited by sourcery-ai bot Loading

RuboCop 1.70

New features

Bug fixes

Changes

1.70.0 (2025-01-10)

New features

Bug fixes

Changes

Summary by Sourcery

sourcery-ai bot commented Jan 13, 2025 • edited Loading

Reviewer's Guide by Sourcery

Class diagram showing new RuboCop cops in v1.70.0

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

Choose a reason for hiding this comment

dependabot bot commented on behalf of github Jan 13, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 13, 2025 •

edited

Loading