chore: apply credo recommandations

ahamez · Nov 28, 2024 · 81b16df · 81b16df
1 parent ea047bd
commit 81b16df
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 17 deletions.
diff --git a/benchmarks/handmade_payloads.exs b/benchmarks/handmade_payloads.exs
@@ -39,7 +39,7 @@ defmodule Protox.Benchmarks.HandmadePayloads do
         a: 3342,
         b: "dqsqsdcqsqddqsqsd qsdqs dqsd ",
         c: -4_678_909_765,
-        d: 29232,
+        d: 29_232,
         e: 8_938_293,
         f: -242_424,
         bbb: <<1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15>>,
@@ -63,7 +63,7 @@ defmodule Protox.Benchmarks.HandmadePayloads do
         g: [
           3,
           270,
-          86942,
+          86_942,
           13,
           22,
           3423,
@@ -72,11 +72,11 @@ defmodule Protox.Benchmarks.HandmadePayloads do
           12,
           98,
           142_442,
-          14500,
+          14_500,
           0,
           3,
           270,
-          86942,
+          86_942,
           13,
           22,
           3423,
@@ -85,11 +85,11 @@ defmodule Protox.Benchmarks.HandmadePayloads do
           12,
           98,
           142_442,
-          14500,
+          14_500,
           0,
           3,
           270,
-          86942,
+          86_942,
           13,
           22,
           3423,
@@ -98,11 +98,11 @@ defmodule Protox.Benchmarks.HandmadePayloads do
           12,
           98,
           142_442,
-          14500,
+          14_500,
           0,
           3,
           270,
-          86942,
+          86_942,
           13,
           22,
           3423,
@@ -111,11 +111,11 @@ defmodule Protox.Benchmarks.HandmadePayloads do
           12,
           98,
           142_442,
-          14500,
+          14_500,
           0,
           3,
           270,
-          86942,
+          86_942,
           13,
           22,
           3423,
@@ -124,11 +124,11 @@ defmodule Protox.Benchmarks.HandmadePayloads do
           12,
           98,
           142_442,
-          14500,
+          14_500,
           0,
           3,
           270,
-          86942,
+          86_942,
           13,
           22,
           3423,
@@ -137,11 +137,11 @@ defmodule Protox.Benchmarks.HandmadePayloads do
           12,
           98,
           142_442,
-          14500,
+          14_500,
           0,
           3,
           270,
-          86942,
+          86_942,
           13,
           22,
           3423,
@@ -150,7 +150,7 @@ defmodule Protox.Benchmarks.HandmadePayloads do
           12,
           98,
           142_442,
-          14500,
+          14_500,
           0,
           3
         ]

diff --git a/lib/protox/guards.ex b/lib/protox/guards.ex
@@ -4,8 +4,8 @@ defmodule Protox.Guards do
   @integers_fixed32 [:fixed32, :sfixed32]
   @integers_fixed64 [:fixed64, :sfixed64]
 
-  @primitives_fixed32 @integers_fixed32 ++ [:float]
-  @primitives_fixed64 @integers_fixed64 ++ [:double]
+  @primitives_fixed32 [:float | @integers_fixed32]
+  @primitives_fixed64 [:double | @integers_fixed64]
   @primitives_fixed @primitives_fixed32 ++ @primitives_fixed64
 
   @primitives_varint32 [:int32, :uint32, :sint32]
-Original file line number
+Diff line change
@@ Expand Up / @@ -39,7 +39,7 @@ defmodule Protox.Benchmarks.HandmadePayloads do @@
             a: 3342,
             b: "dqsqsdcqsqddqsqsd qsdqs dqsd ",
             c: -4_678_909_765,
-            d: 29232,
+            d: 29_232,
             e: 8_938_293,
             f: -242_424,
             bbb: <<1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15>>,
@@ Expand All / @@ -63,7 +63,7 @@ defmodule Protox.Benchmarks.HandmadePayloads do @@
             g: [
 ,
 ,
-,
+_942,
 ,
 ,
 ,
@@ Expand All / @@ -72,11 +72,11 @@ defmodule Protox.Benchmarks.HandmadePayloads do @@
 ,
 ,
 _442,
-,
+_500,
 ,
 ,
 ,
-,
+_942,
 ,
 ,
 ,
@@ Expand All / @@ -85,11 +85,11 @@ defmodule Protox.Benchmarks.HandmadePayloads do @@
 ,
 ,
 _442,
-,
+_500,
 ,
 ,
 ,
-,
+_942,
 ,
 ,
 ,
@@ Expand All / @@ -98,11 +98,11 @@ defmodule Protox.Benchmarks.HandmadePayloads do @@
 ,
 ,
 _442,
-,
+_500,
 ,
 ,
 ,
-,
+_942,
 ,
 ,
 ,
@@ Expand All / @@ -111,11 +111,11 @@ defmodule Protox.Benchmarks.HandmadePayloads do @@
 ,
 ,
 _442,
-,
+_500,
 ,
 ,
 ,
-,
+_942,
 ,
 ,
 ,
@@ Expand All / @@ -124,11 +124,11 @@ defmodule Protox.Benchmarks.HandmadePayloads do @@
 ,
 ,
 _442,
-,
+_500,
 ,
 ,
 ,
-,
+_942,
 ,
 ,
 ,
@@ Expand All / @@ -137,11 +137,11 @@ defmodule Protox.Benchmarks.HandmadePayloads do @@
 ,
 ,
 _442,
-,
+_500,
 ,
 ,
 ,
-,
+_942,
 ,
 ,
 ,
@@ Expand All / @@ -150,7 +150,7 @@ defmodule Protox.Benchmarks.HandmadePayloads do @@
 ,
 ,
 _442,
-,
+_500,
 ,
             ]
@@ Expand Down @@