Add maximum likelihood expectation-maximization (EM) algorithm #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding this reconstruction algorithm! It looks good. Could you add a few tests? I think it is hard to test for specific outcomes, so I don't think you have to do that. I would like to have at least one test running the algorithm, so that you can test that it doesn't throw exceptions. Other algorithms have tests to test things like CUDA support or if continuing from an earlier result (using x_init) will affect the outcome. I leave it up to you if any test like that is useful here as well. |
|
Sure, makes sense! I will try to add it soon. |
|
Sorry, this PR fell thorough the cracks. I've just added the tests, so ready it's for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation aims to reproduce the 'EM' algorithm of Astra Toolbox.