Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename packages to shared, update: readme #14

Merged
merged 2 commits into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/verify-pr-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ jobs:

- name: Create .env file
run: |
touch ./packages/sdk/.env
echo API_USERNAME=${{ secrets.API_USERNAME }} >> ./packages/sdk/.env
echo API_PASSWORD=${{ secrets.API_PASSWORD }} >> ./packages/sdk/.env
touch ./shared/sdk/.env
echo API_USERNAME=${{ secrets.API_USERNAME }} >> ./shared/sdk/.env
echo API_PASSWORD=${{ secrets.API_PASSWORD }} >> ./shared/sdk/.env

- run: npx nx format:check
- run: npx nx affected -t lint,test,build --parallel=3
18 changes: 9 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

Repo for practicing different tools

List of things being practiced
List of things done so far

- Created NX workspace
- Created react app via nx
- Created ui lib via nx
- Added storybook in ui lib via nx
- Added i18n translations
- Added locize integration
- Added github action to verify build of affected nx projects
- Added Api class in sdk lib to provie an interfaace for fetching
- [x] Created nx workspace
- [x] Created react app via nx
- [x] Created ui lib via nx
- [x] Added storybook in ui lib via nx
- [x] Added i18n translations
- [x] Added locize integration
- [x] Added github action to verify lint, test & build of affected nx projects
- [x] Added Api class in sdk lib to provide an interfaace for fetching
2 changes: 1 addition & 1 deletion apps/asdf/.env.sample
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
LOCIZE_PROJECT_ID=your-locize-project-id
LOCIZE_API_KEY=your-locize-api-key
LOCIZE_API_KEY=your-locize-api-key
1 change: 1 addition & 0 deletions apps/asdf/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,6 @@ export default defineConfig({
reportsDirectory: '../../coverage/apps/asdf',
provider: 'v8',
},
passWithNoTests: true,
},
});
Loading