don’t log errors in subroutines and instead handle at top level

ahrefs · Dec 23, 2020 · b47ab24 · b47ab24
1 parent 7517aeb
commit b47ab24
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/lib/state.ml b/lib/state.ml
@@ -17,6 +17,4 @@ let log = Log.from "state"
 let save state path =
   let data = State_j.string_of_state state |> Yojson.Basic.from_string |> Yojson.Basic.pretty_to_string in
   try Lwt.return @@ Ok (write_to_local_file ~data path)
-  with Sys_error e ->
-    log#error "failed to write to local file %s: %s" path e;
-    Lwt.return @@ fmt_error "failed to save state"
+  with Sys_error e -> Lwt.return @@ fmt_error "error while writing to local file %s: %s\nfailed to save state" path e