Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial load of config/state/secrets #99

Merged
merged 4 commits into from
Dec 29, 2020

Conversation

yasunariw
Copy link
Collaborator

@yasunariw yasunariw commented Dec 24, 2020

Description of the task

Some code got lost after rebasing, which broke the entrypoints of workflows that could only be manually tested. Fixes:

  • Initialize secrets in auxiliary command check_gh
  • Only print config after initialization
  • Handle case where state file path --state is provided but actual file doesn't yet exist
  • Correctly build commit url path from template string

How to test

Compile main executable and run the commands with different flags.

  • _build/default/src/notabot.exe check_gh mock_payloads/status.success_test_main_branch.json --state state.json
  • _build/default/src/notabot.exe run -a 0.0.0.0 -p 8080 --state state.json

References

@yasunariw yasunariw changed the title Hotfix/config init and cli flags Fix initial load of config/state/secrets Dec 24, 2020
@yasunariw yasunariw requested a review from ygrek December 24, 2020 07:43
@yasunariw yasunariw merged commit c42b86f into master Dec 29, 2020
@yasunariw yasunariw deleted the hotfix/config-init-and-cli-flags branch December 29, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants