-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile the PR #65 in MDE repo in a separate library #1
Conversation
…ntPreamble (as per PR #376).
…ally. If reader is going to throw an exception reading next byte, break out. This stops Metadataextractor.dll from throwing 'end of data reached' exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some build warnings from nullability annotations, but those can be fixed in a separate change
Note: My knowledge of the jpeg format is very basic, so I can't say for certain if the file parts are right (think we'll have to leave that part up to the original author of the MDE code) |
I did test the output image from this code with other libraries. https://github.com/Exiv2/exiv2 and XMP-Toolkit-SDK. Both of these were able to read the jpeg segments and correctly get the xmp out of that. Also, checked if this lib identifies different segments correctly as per this spec: https://docs.fileformat.com/image/jpeg/. But not knowing a lot of jpeg myself, couldn't say if something might break in the future |
Took the code from this PR: drewnoakes/metadata-extractor-dotnet#65 and compiled that into a separate library as a plugin to MDE