Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile the PR #65 in MDE repo in a separate library #1

Merged
merged 30 commits into from
Mar 20, 2024

Conversation

ahsanaman92
Copy link
Owner

Took the code from this PR: drewnoakes/metadata-extractor-dotnet#65 and compiled that into a separate library as a plugin to MDE

@ahsanaman92 ahsanaman92 self-assigned this Feb 28, 2024
Numpsy
Numpsy previously approved these changes Mar 5, 2024
Ahsan Cheema added 4 commits March 15, 2024 12:32
@ahsanaman92 ahsanaman92 requested a review from Numpsy March 15, 2024 19:19
Copy link
Collaborator

@Numpsy Numpsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some build warnings from nullability annotations, but those can be fixed in a separate change

@Numpsy
Copy link
Collaborator

Numpsy commented Mar 20, 2024

Note: My knowledge of the jpeg format is very basic, so I can't say for certain if the file parts are right (think we'll have to leave that part up to the original author of the MDE code)

@ahsanaman92
Copy link
Owner Author

Note: My knowledge of the jpeg format is very basic, so I can't say for certain if the file parts are right (think we'll have to leave that part up to the original author of the MDE code)

I did test the output image from this code with other libraries. https://github.com/Exiv2/exiv2 and XMP-Toolkit-SDK. Both of these were able to read the jpeg segments and correctly get the xmp out of that. Also, checked if this lib identifies different segments correctly as per this spec: https://docs.fileformat.com/image/jpeg/. But not knowing a lot of jpeg myself, couldn't say if something might break in the future

@ahsanaman92 ahsanaman92 reopened this Mar 20, 2024
@ahsanaman92 ahsanaman92 merged commit 302180d into main Mar 20, 2024
@ahsanaman92 ahsanaman92 deleted the CompileLibrary branch March 20, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants