Implement RandomPolicy #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
fedebotu
reviewed
Aug 30, 2023
| def forward( | ||
| self, | ||
| td: TensorDict, | ||
| env: Union[str, RL4COEnvBase] = None, |
There was a problem hiding this comment.
How about setting themax_steps to inf by default?
Since there may be cases in which one wants to test a very large scale problem, but this max_steps is kinda hardcoded. Or, perhaps we can log a warning if this happens
There was a problem hiding this comment.
I set the default value of max_steps as None. If max_steps=None, rollout decodes until it finds the environments are done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update contains the implementation of the
RandomPolicyclassThe random policy constructs solutions with randomly chosen actions.
Motivation and Context
Having a random policy can be useful during the development of a new environment to perform the sanity check.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!