Skip to content

Commit

Permalink
ci: disable format on autosave
Browse files Browse the repository at this point in the history
This was especially annoying in docstrings (which added intended indents while editing). Now we format on explicit save.
  • Loading branch information
IgnacioHeredia committed Dec 2, 2024
1 parent 88fc55d commit 3b4a076
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
1 change: 0 additions & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@
"recommendations": [
"ms-python.python",
"charliermarsh.ruff",
"bdsoftware.format-on-auto-save"
]
}
3 changes: 1 addition & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
{
"[python]": {
"editor.defaultFormatter": "charliermarsh.ruff",
"editor.formatOnSave": true
"editor.formatOnSave": true,
},
"files.autoSave": "afterDelay",
"editor.rulers": [
88
],
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,6 @@ The pattern for the subfolders follows:
### Implementation notes

This repository is formatted with [Ruff](https://docs.astral.sh/ruff/).
We use [Ruff](https://marketplace.visualstudio.com/items?itemName=charliermarsh.ruff) and [FormatOnSave](https://marketplace.visualstudio.com/items?itemName=BdSoftware.format-on-auto-save) ([issue](https://github.com/microsoft/vscode/issues/45997#issuecomment-950405496)) VScode extensions to make the development workflow smoother.
We provide some [default VScode configuration](.vscode) to make the development workflow smoother.

We use [Precommit](https://pre-commit.com/) locally to enforce format in commits. Then use [Precommit.CI](https://pre-commit.ci/) to enforce it at the Github level.

0 comments on commit 3b4a076

Please sign in to comment.