refactor: active endpoints

ai4os · Nov 18, 2024 · d2805eb · d2805eb
1 parent 2c6f2f8
commit d2805eb
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/ai4papi/nomad/common.py b/ai4papi/nomad/common.py
@@ -260,8 +260,13 @@ def get_deployment(
             info['active_endpoints'] = []
             for k, v in info['endpoints'].items():
                 try:
+                    # We use GET and not HEAD, because HEAD is not returning the correct status_codes (even with "allow_redirects=True")
+                    # Anyway, both latencies are almost the same when using "allow_redirects=True"
+                    # * IDE deployed: GET (200), HEAD (405) | latency: ~90 ms
+                    # * API not deployed: GET (502), HEAD (502) | latency: ~40 ms
+                    # * Non existing domain: GET (404), HEAD (404) | latency: ~40 ms
                     r = session.get(v, timeout=2)
-                    if r.status_code == 200:
+                    if r.ok:
                         info['active_endpoints'].append(k)
                 except (requests.exceptions.Timeout, requests.exceptions.ConnectionError):
                     continue