Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized function signature for models. #3

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

ErnstRoell
Copy link
Contributor

Request change in the function signature of forward for the models since the toponetx models have a different signature and that would yield issues down the road.

Changes:

  • Manually calculate the batch length (either in batch.batch or last arg of batch)
  • change signature of forward to def forward(self, batch)

@danielbinschmid danielbinschmid merged commit 4b204a8 into main Jun 14, 2024
2 checks passed
@danielbinschmid danielbinschmid deleted the mantra-dev-er branch June 14, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants