Updating the *before_notebook* 20_start-postgresql.sh and 40_prepare_aiida.sh
#475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for arm64 I encountered the issues in restarting the container.
1- Deleting old ${PSQL_LOGFILE}.1.gz file before trying to compressed again. Otherwise, this can give errors and so the container will exit with non-zero status.
2- Clean stop of the daemon before the "verdi storage migrate --force" in `40_prepare_aiida.sh`. This is done because sometimes the restart of the docker container will give error in trying to migrate,
as the daemon is still running. I am not able to reproduce the error in a standard way, however.
for more information, see https://pre-commit.ci
|
I forgot that the test are not working if the PR is from outside. I fill create the PR from this repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixings are done as for arm64 I encountered issues in restarting the container.
1 - Deleting old ${PSQL_LOGFILE}.1.gz file before trying to compressed again in
20_start-postgresql.sh. Otherwise, this can give errors and so the container will exit with non-zero status.2 - Clean stop of the daemon before the "verdi storage migrate --force" in
40_prepare_aiida.sh. This is done because sometimes the restart of the docker container will give error in trying to migrate, as the daemon is still running. I am not able to reproduce the error in a standard way, however.