Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin docker/bake-action to fix build #492

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Pin docker/bake-action to fix build #492

merged 8 commits into from
Aug 7, 2024

Conversation

danielhollas
Copy link
Contributor

Fixes #491

@danielhollas danielhollas requested a review from unkcpz August 7, 2024 16:26
@danielhollas
Copy link
Contributor Author

danielhollas commented Aug 7, 2024

I've been able to workaround the original issue detailed in #491, but then ran into another one since the specification of the metadata json changes and the jq script in extract-image-names.sh no longer works. So for now I've pinned the bake-action to the previous version. I have nevertheless kept the workaround/fix since I think it is better then the original approach.

I opened #493 as a followup on this.

@danielhollas danielhollas enabled auto-merge (squash) August 7, 2024 17:28
@danielhollas danielhollas changed the title Fix build Pin docker/bake-action to fix build Aug 7, 2024
@danielhollas danielhollas disabled auto-merge August 7, 2024 19:25
@danielhollas danielhollas merged commit 5ee3ab8 into main Aug 7, 2024
15 checks passed
@danielhollas danielhollas deleted the fix-build branch August 7, 2024 19:27
@unkcpz
Copy link
Member

unkcpz commented Aug 8, 2024

Parsing things with jq is already quite complex to me. I am interested to know how you debug it?

@danielhollas
Copy link
Contributor Author

I am also unfamiliar with jq. The original error was caused by bash. Once I fixed it I ran into a jq error https://github.com/aiidalab/aiidalab-docker-stack/actions/runs/10287638235/job/28471150939

jq: error (at bake_metadata.json:691): Cannot index array with string "image.name"

I have verified that the json schema indeed changed, but I did not debug further and opened #493. I think the fix will be simple for somebody who knows jq. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing build
2 participants