-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add a Filter to tar.extractall
Method
#6770
base: main
Are you sure you want to change the base?
Conversation
@danielhollas Hi, I have worked on the issue #6657 and I will appreciate any review :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6770 +/- ##
==========================================
- Coverage 78.15% 78.15% -0.00%
==========================================
Files 564 564
Lines 42643 42645 +2
==========================================
+ Hits 33322 33323 +1
- Misses 9321 9322 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jgyasu thank you! This looks good, just one suggestion.
Codecov reports one uncovered line, but that's because we only collect code coverage for Python 3.9 so that is to be expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided that the tests pass this looks good to me, thanks!
(I don't have the commit bit on this repo, so asking @agoscinski for review as well)
Fixes #6657
This PR adds the
data
filter to thetar.extractall
method such that it does not raise a depreciation warning if the Python version >= 3.12.