Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add a Filter to tar.extractall Method #6770

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jgyasu
Copy link

@jgyasu jgyasu commented Feb 23, 2025

Fixes #6657

This PR adds the data filter to the tar.extractall method such that it does not raise a depreciation warning if the Python version >= 3.12.

@jgyasu
Copy link
Author

jgyasu commented Feb 23, 2025

@danielhollas Hi, I have worked on the issue #6657 and I will appreciate any review :)

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.15%. Comparing base (f4c55f5) to head (4eb40ef).

Files with missing lines Patch % Lines
...da/storage/sqlite_zip/migrations/legacy_to_main.py 66.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6770      +/-   ##
==========================================
- Coverage   78.15%   78.15%   -0.00%     
==========================================
  Files         564      564              
  Lines       42643    42645       +2     
==========================================
+ Hits        33322    33323       +1     
- Misses       9321     9322       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas danielhollas self-requested a review February 23, 2025 23:45
Copy link
Collaborator

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jgyasu thank you! This looks good, just one suggestion.

Codecov reports one uncovered line, but that's because we only collect code coverage for Python 3.9 so that is to be expected.

Copy link
Collaborator

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided that the tests pass this looks good to me, thanks!

(I don't have the commit bit on this repo, so asking @agoscinski for review as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TarFile.extract raises DeprecationWarning since Python 3.12
2 participants