blockchainTriggerFilter & deploy url check #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoojinko
reviewed
Jan 5, 2024
src/middlewares/middleware.ts
Outdated
| this.cache.set(txHash, "in_progress", 500); | ||
| next(); | ||
| _.isEqual(result, triggerValue) ? res.send("not from blockChain") : next(); |
There was a problem hiding this comment.
result와 triggerValue 가 같으면 not from blockChain인가요??
There was a problem hiding this comment.
반대로 적은 것 같네요 수정하였습니다!
|
LGTM, Thanks! |
yoojinko
approved these changes
Jan 22, 2024
|
Thanks! now merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blockchainTriggerFilter
deploy url check
getDataFromServiceRequest, getDataFromDepositRequest util로 이동.
await this.checkRunning