Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that C extension is correctly loaded #1475

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

lysnikolaou
Copy link
Contributor

What do these changes do?

  • Adds a test that the C extensions are loaded okay.

Are there changes in behavior for the user?

No.

Copy link

codspeed-hq bot commented Feb 25, 2025

CodSpeed Performance Report

Merging #1475 will improve performances by 8.93%

Comparing lysnikolaou:add-tests-c-extension-loaded (b241d39) with master (426b7ac)

Summary

⚡ 1 improvements
✅ 98 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_url_with_port 329.1 µs 302.1 µs +8.93%

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (426b7ac) to head (b241d39).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1475   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          33       33           
  Lines        6006     6010    +4     
  Branches      364      364           
=======================================
+ Hits         5740     5744    +4     
  Misses        240      240           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.57% <100.00%> (+<0.01%) ⬆️
MyPy 49.71% <50.00%> (+<0.01%) ⬆️
OS-Linux 98.83% <100.00%> (+<0.01%) ⬆️
OS-Windows 98.85% <100.00%> (+<0.01%) ⬆️
OS-macOS 98.58% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 98.56% <100.00%> (+<0.01%) ⬆️
Py-3.10.16 98.79% <100.00%> (+<0.01%) ⬆️
Py-3.11.11 98.79% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 98.56% <100.00%> (+<0.01%) ⬆️
Py-3.12.8 98.56% <100.00%> (+<0.01%) ⬆️
Py-3.12.9 98.79% <100.00%> (+<0.01%) ⬆️
Py-3.13.1 98.56% <100.00%> (+<0.01%) ⬆️
Py-3.13.2 98.79% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.52% <100.00%> (+<0.01%) ⬆️
Py-3.9.21 98.75% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 98.74% <75.00%> (-0.03%) ⬇️
Py-pypy7.3.18 98.76% <75.00%> (-0.03%) ⬇️
VM-macos-latest 98.58% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 98.83% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 98.85% <100.00%> (+<0.01%) ⬆️
pytest 98.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Feb 25, 2025
@bdraco
Copy link
Member

bdraco commented Feb 25, 2025

Thanks @lysnikolaou

@bdraco bdraco merged commit 0db43c6 into aio-libs:master Feb 25, 2025
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants