Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bk/add swift linting #270

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Bk/add swift linting #270

merged 2 commits into from
Sep 19, 2023

Conversation

bryankeller
Copy link
Contributor

Details

Add Swift format support and enforce Airbnb's style guide

Related Issue

N/A

Motivation and Context

Automatic linting and style guide enforcement

How Has This Been Tested

Example app compiles, tests compile and pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project. 😎
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@bryankeller bryankeller added the enhancement New feature or request label Sep 19, 2023
calda
calda previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@calda calda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Glad to have more adoption of our swift package plugin

calda
calda reviewed Sep 19, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
calda
calda reviewed Sep 19, 2023
View reviewed changes
Package.swift Show resolved Hide resolved
@bryankeller bryankeller requested a review from calda September 19, 2023 20:18
calda
calda previously approved these changes Sep 19, 2023
View reviewed changes
@calda calda merged commit 0ac7498 into master Sep 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calda calda calda approved these changes

@brynbodayle brynbodayle Awaiting requested review from brynbodayle

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryankeller @calda