Accessibility scrolling enhancements #283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When scrolling the
CalendarView
via accessibility methods (specifically using the 3 finger swipe with voiceover), the related scrolling delegate methods (didScroll
,didEndDragging
, anddidEndDecelerating
) were not called.This could lead to missing functionality for surfaces which relied on those callbacks to implement functionality, such as loading new data from the network when scrolling to new a new data range.
This PR adds those callbacks to the
accessibilityScroll
method, ensuring that they're fired whenever a user scrolls - whether through accessibility means or not.Related Issue
Motivation and Context
How Has This Been Tested
Tested changes in example app on device to ensure that the relevant delegate methods are called.
Types of changes
Checklist