Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility scrolling enhancements #283

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

andrewwilliams
Copy link
Contributor

@andrewwilliams andrewwilliams commented Nov 18, 2023

Details

When scrolling the CalendarView via accessibility methods (specifically using the 3 finger swipe with voiceover), the related scrolling delegate methods (didScroll, didEndDragging, and didEndDecelerating) were not called.

This could lead to missing functionality for surfaces which relied on those callbacks to implement functionality, such as loading new data from the network when scrolling to new a new data range.

This PR adds those callbacks to the accessibilityScroll method, ensuring that they're fired whenever a user scrolls - whether through accessibility means or not.

Related Issue

Motivation and Context

How Has This Been Tested

Tested changes in example app on device to ensure that the relevant delegate methods are called.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

@jpsoultanis jpsoultanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bryankeller
Copy link
Contributor

Thanks Andrew! Left one comment / question. Also, could you update the CHANGELOG.md? This can be under the "Fixed" section.

@bryankeller bryankeller added the bug Something isn't working label Nov 22, 2023
@bryankeller bryankeller merged commit 76b8bd8 into airbnb:master Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants