Improve initial accessibility focus behavior #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryankeller
force-pushed
the
bk/improve-accessibility-initial-focus
branch
from
3a88e9a to
4f0a96d
Compare
antonredkozubov
added a commit
to antonredkozubov/HorizonCalendar
that referenced
this pull request
Dec 5, 2023
Improve initial accessibility focus behavior (airbnb#286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This change improves the initial element focus behavior. Since we started creating more accessibility elements than are visible to prevent the "heading not found" issue, we introduced a different issue - the first accessibility element is now off screen, and so focusing on that feels unnatural. This PR ensures that an item in the visible range of dates is focused when first entering the calendar via voice over.
Related Issue
N/A
Motivation and Context
Improves accessibility focus behavior.
How Has This Been Tested
Example app on device.
Types of changes
Checklist