Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling touches via allowsHitTesting #294

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

bryankeller
Copy link
Contributor

Details

This PR enables folks to disable user interaction on SwiftUI views by using the allowsHitTesting modifier.

Related Issue

#291

Motivation and Context

Fix issues (we also ran into this at Airbnb recently when trying to disable certain days from being tappable)

How Has This Been Tested

Example app

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@bryankeller bryankeller added the bug Something isn't working label Jan 10, 2024
@bryankeller bryankeller merged commit ef63533 into master Jan 10, 2024
3 checks passed
@bryankeller bryankeller deleted the bk/respect-swiftui-allows-hit-testing-modifier branch January 10, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants