Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public initialisers for DayComponent and MonthComponent to support pre-selected date range in the calendar. #306

Closed
wants to merge 3 commits into from

Conversation

MartinBMAR
Copy link

@MartinBMAR MartinBMAR commented May 23, 2024

Details

Added a extension to DayComponent and MonthComponent with a public initialiser.

Related Issue

Motivation and Context

We found the need to programatically select dates in the calendar without user interaction, due to the initialiser for DayComponent and MonthComponent it's not possible for us to initialise a DateComponentRange. To adres this we created new public initialisers for those models.

How Has This Been Tested

  • Running the app and displaying a pre-selected date range in HorizonCalendar.
  • Updating the pre-selected range to ensure user interaction works fine.
  • Running all the tests.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@cccsso
Copy link

cccsso commented Jan 10, 2025

Can we please get these changes reviewed and merged?

@bryankeller
Copy link
Contributor

@MartinBMAR @cccsso you shouldn't need to instantiate any of these types. Please refer to the README for how to handle specifying day ranges. The TL;DR is you should be creating ClosedRange<Date> using your Calendar instance. There is no need to create DayComponent or MonthComponent directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants