Logging failure should fail open

airbnb · Jan 31, 2024 · d7decc9 · d7decc9
1 parent e663aef
commit d7decc9
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/online/src/main/scala/ai/chronon/online/Fetcher.scala b/online/src/main/scala/ai/chronon/online/Fetcher.scala
@@ -291,7 +291,8 @@ class Fetcher(val kvStore: KVStore,
           codec.loggingSchemaHash
         )
         if (logFunc != null) {
-          logFunc.accept(loggableResponse)
+          val sentLog = Try(logFunc.accept(loggableResponse))
+          if (sentLog.isFailure) logger.error("Failed to publish log", sentLog.failed.get)
           joinContext.foreach(context => context.increment("logging_request.count"))
           joinContext.foreach(context =>
             context.distribution("logging_request.latency.millis", System.currentTimeMillis() - loggingStartTs))