Improvements to TileCodec to compress and skip redundant windows #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # online/src/main/scala/ai/chronon/online/GroupByServingInfoParsed.scala # online/src/main/scala/ai/chronon/online/TileCodec.scala # spark/src/test/scala/ai/chronon/spark/test/InMemoryStream.scala
# Conflicts: # online/src/test/scala/ai/chronon/online/TileCodecTest.scala
nikhilsimha
reviewed
Aug 4, 2023
nikhilsimha
reviewed
Aug 4, 2023
| bucketPos += 1 | ||
| } | ||
| } | ||
| flattenedIr |
There was a problem hiding this comment.
it might be more efficient to directly implement and not pay for the intermediate collection.
updateFlatWithTile(historicalFlatIr, tileIr) vs. update(historicalFlatIr, flatten(tile))
nikhilsimha
approved these changes
Aug 4, 2023
caiocamatta-stripe
approved these changes
Sep 28, 2023
aarongreen-stripe
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up from our prior TileCodec PR - #523 (comment)
Made some changes to TileCodec to not compute and store the full cross product of buckets * windows for a given FG. The window are redundant within a tile and costs us on the aggregator side + on the payload ser / deser side. Now we'll only have one counter for given aggregation, bucket in a tile. We explode this out on the deser side so that this continues to work with @aarongreen-stripe's PR - #531.
Why / Goal
Improve aggregation efficiency and cut down tile payload sizes written out to KV store
Test Plan
Checklist
Reviewers
@nikhilsimha || @ezvz