Chaining fix #567
Merged
Chaining fix #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SophieYu41
force-pushed
the
chaining_fix
branch
from
e2644df to
58de450
Compare
SophieYu41
reviewed
Sep 26, 2023
nikhilsimha
commented
Sep 26, 2023
api/py/ai/chronon/group_by.py
Outdated
| @@ -431,6 +431,7 @@ def _normalize_source(source): | |||
| elif isinstance(source, ttypes.EntitySource): | |||
| return ttypes.Source(entities=source) | |||
| elif isinstance(source, ttypes.JoinSource): | |||
| source.join.metadata = output_namespace or source.metaData.outputNamespace | |||
There was a problem hiding this comment.
should this be
Suggested change
| source.join.metadata = output_namespace or source.metaData.outputNamespace | |
| if not source.join.metadata.isSetOutputNamespace(): | |
| source.join.metadata.setOutputNamespace(output_namespace) |
There was a problem hiding this comment.
cc @better365 for another eye. Working locally but does not seem to be effective when trying to test with user conf.
nikhilsimha
commented
Sep 26, 2023
api/py/test/sample/production/joins/sample_team/sample_join_external_parts.v1
Outdated
Show resolved
Hide resolved
nikhilsimha
commented
Sep 26, 2023
nikhilsimha
commented
Sep 26, 2023
added 2 commits
September 26, 2023 12:02
nikhilsimha
commented
Sep 26, 2023
SophieYu41
approved these changes
Sep 26, 2023
pengyu-hou
reviewed
Sep 26, 2023
| println(s"Historical backfill is set to false. Backfill single partition only: $endPartition") | ||
| Some(endPartition) | ||
| } | ||
| lazy val defaultLeftStart = Option(leftSource.query.startPartition) |
There was a problem hiding this comment.
this is a great way to avoid version checking.
pengyu-hou
reviewed
Sep 26, 2023
| @@ -431,6 +431,8 @@ def _normalize_source(source): | |||
| elif isinstance(source, ttypes.EntitySource): | |||
| return ttypes.Source(entities=source) | |||
| elif isinstance(source, ttypes.JoinSource): | |||
| if not source.join.metadata.isSetOutputNamespace(): | |||
| source.join.metadata.setOutputNamespace(output_namespace) | |||
There was a problem hiding this comment.
because the output namespace is empty in the join source python object. It has to be read from the teams.json similar to this method: https://github.com/airbnb/chronon/blob/master/api/py/ai/chronon/repo/compile.py#L122
pengyu-hou
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
historicalBackfillto allow no "catch-up" backfill but only backfill single day DS for homes use caseWhy / Goal
Test Plan
Checklist
Reviewers