Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate join part in compile.py #609

Merged
merged 1 commit into from
Nov 9, 2023
Merged

validate join part in compile.py #609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/py/ai/chronon/join.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import ai.chronon.api.ttypes as api
import ai.chronon.repo.extract_objects as eo
import ai.chronon.utils as utils
from ai.chronon.group_by import validate_group_by
import copy
import gc
import importlib
Expand Down Expand Up @@ -537,6 +538,7 @@ def Join(left: api.Source,
join_part_name = "{}{}".format(
join_part.prefix + "_" if join_part.prefix else "", join_part.groupBy.metaData.name)
join_part_tags[join_part_name] = join_part.tags
validate_group_by(join_part.groupBy)
custom_json["join_part_tags"] = join_part_tags

consistency_sample_percent = consistency_sample_percent if check_consistency else None
Expand Down