-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DocBash] adding chaining feature documentation #669
Conversation
If you have similar features which would require multiple joins or groupbys, chaining features might be a good fit for your use case. | ||
|
||
## How do I use it? | ||
We introduced a new source type **JoinSource**. You can now pass in a parent join as Source in GroupBys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may want to re-wording a bit stating it as a fact and removing "new feature" emphasis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, @better365 !
A few suggestions.
Also, you need to modify the website code to add a page for this new document. I'd suggest adding it after the join
documentation.
Co-authored-by: Varant Zanoyan <[email protected]> Signed-off-by: Pengyu Hou <[email protected]>
Co-authored-by: Varant Zanoyan <[email protected]> Signed-off-by: Pengyu Hou <[email protected]>
Co-authored-by: Varant Zanoyan <[email protected]> Signed-off-by: Pengyu Hou <[email protected]>
Co-authored-by: Varant Zanoyan <[email protected]> Signed-off-by: Pengyu Hou <[email protected]>
Co-authored-by: Varant Zanoyan <[email protected]> Signed-off-by: Pengyu Hou <[email protected]>
Co-authored-by: Varant Zanoyan <[email protected]> Signed-off-by: Pengyu Hou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @better365
Summary
Add documentation for chaining features
Why / Goal
Doc Bash
Test Plan
Checklist
Reviewers
@airbnb/zipline-maintainers