Use thread-safe FastDateFormat in TsUtils.scala #676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use FastDateFormat instead of SimpleDateFormat in TsUtils.scala
Why / Goal
We recently introduced some parallelizations that included this logging in SawtoothOnlineAggregator.scala. Since SimpleDateFormat is not thread-safe, we ran into some race conditions with these logs. In order to resolve this, we can instead use the thread-safe FastDateFormat
Test Plan
Reviewers