Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StatsFetch] Ignore bad decodes #677

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

cristianfr
Copy link
Collaborator

@cristianfr cristianfr commented Feb 1, 2024

Summary

We store the schema in the KVStore, however it's possible for the KVStore to still contain values that are outdated.
To prevent completely failing the fetch, it's better to just provide nulls when the value schema cannot decode a specific value.

Why / Goal

Reliability.

Test Plan

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested (pushed a snapshot version and did a fetch that was failing)
 }, {
    "millis" : 1706486400000,
    "value" : [ 1.65324518E9, 1.65324518E9, 1.65324518E9, 1.65324518E9, 1.65324518E9 ]
  }, {
    "millis" : 1706382000000,
    "value" : null
  }, {
    "millis" : 1706284800000,
    "value" : null
  }, {
    "millis" : 1706270400000,
    "value" : null
  }, {
    "millis" : 1706223600000,
    "value" : null
  }, {

Checklist

  • Documentation update

Reviewers

@cristianfr cristianfr merged commit 25f5e8b into master Feb 2, 2024
6 of 7 checks passed
@cristianfr cristianfr deleted the crf-ignore-bad-decodes branch February 2, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants