Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #120 it said
nohoist.enable
is set to false in development mode to speed up code bundling.But recently we meet an unexpected issue, that some global CSS styles in a page polluted other page. Consider we have a sub-package
packageA
and a pagepackageA/pages/index
inside it with these CSS:If
nohoist.enable
wasfalse
, these lines of code would be bundled into_goji_commons.wxss
and shared by all pages. Which means all pages' background became red.Therefore, I decided to enable this option by default in case of different behavior on production and development mode.
Also, I tested and found the bundling performance affect is acceptable. See the result of re-bundling time costs ( in ms ) in a large GojiJS project.
nohoist.enable
false
true