add validcation check for zipkinDefaultMaxSpans

airbnb · Dec 6, 2024 · c902119 · c902119
1 parent a14240d
commit c902119
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/astra/src/main/java/com/slack/astra/server/ValidateAstraConfig.java b/astra/src/main/java/com/slack/astra/server/ValidateAstraConfig.java
@@ -50,6 +50,9 @@ private static void validateQueryConfig(AstraConfigs.QueryServiceConfig queryCon
         queryConfig.getServerConfig().getRequestTimeoutMs()
             > queryConfig.getDefaultQueryTimeoutMs(),
         "QueryConfig requestTimeoutMs must be higher than defaultQueryTimeoutMs");
+    checkArgument(
+        queryConfig.getZipkinDefaultMaxSpans() >= 1000,
+        "QueryConfig zipkinDefaultMaxSpans cannot less than 1000");
   }
 
   private static void validateCacheConfig(AstraConfigs.CacheConfig cacheConfig) {