config changes to get kaldb working locally #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autata
commented
Feb 14, 2024
| @@ -9,7 +9,7 @@ services: | |||
| - ALLOW_ANONYMOUS_LOGIN=yes | |||
|
|
|||
| kafka: | |||
| image: 'bitnami/kafka:3.2.3' | |||
| image: 'bitnami/kafka:latest' | |||
There was a problem hiding this comment.
todo: pin working version
| private static int getHowMany(JsonNode body) { | ||
| return body.get("size").asInt(); | ||
| } | ||
|
|
||
| // This is required. consider returning a more useful error to the user than 500 | ||
| // or setting a reasonable default (not sure what that would be) |
There was a problem hiding this comment.
probably should return something like this instead of 500
{
"error": {
"code": 400,
"message": "Bad Request",
"details": "The 'query.gte' field is required but missing in the request."
}
}
| @@ -85,14 +85,20 @@ private static String getQueryString(JsonNode body) { | |||
| return queryString; | |||
| } | |||
|
|
|||
| // This is required. consider returning a more useful error to the user than 500 | |||
| // or setting a reasonable default (default seems a good option here) | |||
There was a problem hiding this comment.
probably should use whatever default size ES uses so it works like their docs
mansu
reviewed
Feb 14, 2024
| @@ -1,5 +1,7 @@ | |||
| <component name="ProjectRunConfigurationManager"> | |||
| <configuration default="false" name="KalDb Query Node" type="Application" factoryName="Application"> | |||
| <option name="ALTERNATIVE_JRE_PATH" value="21" /> | |||
There was a problem hiding this comment.
The run config works for me without this. So, it may be an issue with your intelliJ setup.
|
closing this. separated out into different PRs and opened against the slackhq project |
zarna1parekh
pushed a commit
that referenced
this pull request
Nov 4, 2024
…eout (#1…" (slackhq#1149) This reverts commit d2b61c0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the goal of this PR. Mention any related Issue numbers.
Requirements