Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #699 java.lang.SecurityException #700

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Fixing #699 java.lang.SecurityException #700

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5210a8
Update MavericksMockPrinter.kt
danpe Oct 31, 2023
ebbcd0d
Merge pull request #1 from globekeeper/danpe-patch-1
danpe Oct 31, 2023
4aa5e77
Fixing java.lang.SecurityException
danpe Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mvrx-mocking/src/main/kotlin/com/airbnb/mvrx/mocking/printer/MavericksMockPrinter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import android.content.Context
import android.content.Intent
import android.content.IntentFilter
import android.os.AsyncTask
import android.os.Build
import android.util.Log
import android.view.View
import androidx.fragment.app.Fragment
Expand Down Expand Up @@ -204,6 +205,11 @@ internal abstract class MavericksPrintStateBroadcastReceiver : BroadcastReceiver
fun register(context: Context) {
check(!isRegistered) { "Already registered" }
isRegistered = true
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
context.registerReceiver(networkInfoReceiver, filter, Context.RECEIVER_NOT_EXPORTED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danpe thanks for fixing, but this doesn't seem to compile

MavericksMockPrinter.kt:209:38 Unresolved reference: networkInfoReceiver

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to do what context.registerReceiver(this, IntentFilter(ACTION_COPY_MAVERICKS_STATE)) does below? and that line should be replaced with this new code

Copy link
Contributor Author

@danpe danpe Nov 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @elihart my bad, fixed it.
Samsung just released Android 14 to all its flagship devices, so I believe we'll be seeing more and more crashes due to this...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, but since this is the mocking library it shouldn't be running in production. Do you need to change your configuration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is weird as even if I disable mocking completely it still crashes,

        MockableMavericks.initialize(
            mocksEnabled =false
            debugMode = false,
            applicationContext = this,
            //TODO maybe use other dispatchers
            viewModelCoroutineContext = Dispatchers.Default,
            stateStoreCoroutineContext = Dispatchers.Default
        )

Still crashes on startup...

} else {
context.registerReceiver(networkInfoReceiver, filter)
}
context.registerReceiver(this, IntentFilter(ACTION_COPY_MAVERICKS_STATE))
}

Expand Down
Loading