Support ruby 3.1 #189

RenzoMinelli · 2023-02-01T17:20:31Z

This PR is based on #178 (Author: Brendan Mulholland), these changes are required for this gem to support Ruby 3.1:

Update rubocop to 1.22.x
Update rubocop-rspec to 2.0.x

RenzoMinelli · 2023-02-01T17:30:58Z

rubocop-airbnb/spec/rubocop/cop/airbnb/spec_constant_assignment_spec.rb

-
-    inspect_source(source)
-    expect(cop.offenses.size).to eq(1)
+  it 'rejects constant defined in global space' do


The test's description was changed to reflect what it is being tested.

Thanks! Good correction

RenzoMinelli · 2023-02-01T18:41:51Z

rubocop-airbnb/spec/rubocop/cop/airbnb/module_method_in_wrong_file_spec.rb

-      'end',
-    ].join("\n")
-
+  xit 'rejects with "<<" static methods and a non-matching name' do


This test was set as pending due to the fact that a bug is causing it to fail, suggesting baz to be defined in foo/foo.rb instead of being in foo.rb.

This seems strange to me. Why is the metaclass of Foo expected to be defined in foo/foo.rb? Was this failing previously? I'm assuming this is due to the rubocop upgrade?

I'd like to dig into this one and figure out why this changed

Oh sorry I should have left the link to the issue that I created discussing this. It's a false positive in master.

pariser

Just a few minor questions – thanks for the contibution!

pariser · 2023-02-08T17:58:59Z

rubocop-airbnb/config/rubocop-rspec.yml

@@ -56,7 +56,6 @@ RSpec/DescribedClass:
 RSpec/EmptyExampleGroup:
  Description: Checks if an example group does not include any tests.
  Enabled: true
-  CustomIncludeMethods: []


curious the justification for removing this? is it that the default value is equivalent to empty array?

The upgrade guide to version 2.x of rubocop-rspec indicates that the CustomIncludeMethods configuration option for RSpec/EmptyExampleGroup was removed.

Ah, I must have pulled up an old reference to the EmptyExampleGroup docs. Thanks for the reference.

rubocop-airbnb/lib/rubocop/cop/airbnb/spec_constant_assignment.rb

pariser · 2023-02-08T18:15:37Z

rubocop-airbnb/spec/rubocop/cop/airbnb/module_method_in_wrong_file_spec.rb

-      'end',
-    ].join("\n")
-
+  xit 'rejects with "<<" static methods and a non-matching name' do


This seems strange to me. Why is the metaclass of Foo expected to be defined in foo/foo.rb? Was this failing previously? I'm assuming this is due to the rubocop upgrade?

I'd like to dig into this one and figure out why this changed

pariser · 2023-02-08T18:22:35Z

rubocop-airbnb/spec/rubocop/cop/airbnb/spec_constant_assignment_spec.rb

-
-    inspect_source(source)
-    expect(cop.offenses.size).to eq(1)
+  it 'rejects constant defined in global space' do


Thanks! Good correction

pariser · 2023-02-08T18:47:14Z

rubocop-airbnb/spec/spec_helper.rb

@@ -13,6 +13,8 @@ module SpecHelper
 Dir.glob(spec_helper_glob).map(&method(:require))

 RSpec.configure do |config|
+  config.include RuboCop::RSpec::ExpectOffense


Thanks for switching to ExpectOffense syntax!

RenzoMinelli · 2023-02-09T17:21:28Z

rubocop-airbnb/rubocop-airbnb.gemspec

@@ -25,9 +25,9 @@ Gem::Specification.new do |spec|
    'Gemfile',
  ]

-  spec.add_dependency('rubocop', '~> 0.93.1')
+  spec.add_dependency('rubocop', '~> 1.22.0')


I decided to bump the version to grater than 1.22.0 because if I tried running rubocop with any version between 1.0.0 and 1.21.0 errors would occur, displaying messages like this:

An error occurred while Layout/BlockAlignment cop was inspecting ~/ruby/rubocop-airbnb/spec/rubocop/cop/airbnb/unsafe_yaml_marshal_spec.rb:1:0

Ending with:

Errors are usually caused by RuboCop bugs. Please, report your problems to RuboCop's issue tracker. https://github.com/rubocop/rubocop/issues

pariser · 2023-02-09T23:29:38Z

@RenzoMinelli Thanks! This is great and I'm pretty sure it's ready to go, but I'd love to get tests passing on this branch before we merge. I just merged #191 which switched out travis for github actions (apparently Travis hadn't been working for quite a long time). Would you mind rebasing? You'll have to add ruby 3.1 (and uncomment 3.0) in the CI matrix here.

Co-Authored-By: Brendan Mulholland <[email protected]>

…erns Co-Authored-By: Brendan Mulholland <[email protected]>

Co-Authored-By: Brendan Mulholland <[email protected]>

RenzoMinelli · 2023-02-10T00:12:26Z

@RenzoMinelli Thanks! This is great and I'm pretty sure it's ready to go, but I'd love to get tests passing on this branch before we merge. I just merged #191 which switched out travis for github actions (apparently Travis hadn't been working for quite a long time). Would you mind rebasing? You'll have to add ruby 3.1 (and uncomment 3.0) in the CI matrix here.

I just rebased my branch, but it seems that First-time contributors need a maintainer to approve running workflows

pariser · 2023-02-10T00:18:39Z

Approved your workflow! Tests are failing in 2.4 due to rubocop upgrade. That's a good tradeoff (support 3.1, drop support for 2.4). Feel free to update the matrix, and bump the required_ruby_version (link).

RenzoMinelli · 2023-02-10T12:48:00Z

@pariser seems that an approval in needed for each workflow 😅. I removed 2.4 in the last commit.

pariser · 2023-02-10T16:11:43Z

So it seems! I'll unlock CI right now

pariser

Thank you! I'll merge this and cut a new (major) release today.

RenzoMinelli · 2023-02-10T16:27:54Z

Thank you! I'll merge this and cut a new (major) release today.

Nice! Thanks

RenzoMinelli commented Feb 1, 2023

View reviewed changes

RenzoMinelli mentioned this pull request Feb 1, 2023

RuboCop::Cop::Airbnb::ModuleMethodInWrongFile returns incorrect error message when defining a method inside singleton class #190

Open

pariser reviewed Feb 8, 2023

View reviewed changes

RenzoMinelli commented Feb 9, 2023

View reviewed changes

RenzoMinelli and others added 13 commits February 9, 2023 21:03

build: upgrade rubocop to version 1.22.0

7e106e9

refactor: cops extend Base instead of Cop

472e360

Co-Authored-By: Brendan Mulholland <[email protected]>

refactor: use rubocop standard include instead of rspec specific patt…

3bc1591

…erns Co-Authored-By: Brendan Mulholland <[email protected]>

refactor: add a top-level rspec department

140034e

Co-Authored-By: Brendan Mulholland <[email protected]>

refactor: InvalidPredicateMatcher and CustomIncludeMethods are removed

7a4ca39

Co-Authored-By: Brendan Mulholland <[email protected]>

refactor: require rubocop-rails and rubocop-performance

ecc0dee

Co-Authored-By: Brendan Mulholland <[email protected]>

refactor: include rspec expectOffense

bc350e3

Co-Authored-By: Brendan Mulholland <[email protected]>

refactor: use :config rspec metadata in cop specs

fa36cfc

Co-Authored-By: Brendan Mulholland <[email protected]>

refactor: use expect_offense instead of accessing offenses directly

fc08ca4

Co-Authored-By: Brendan Mulholland <[email protected]>

test: change test description

8fa29e0

Co-Authored-By: Brendan Mulholland <[email protected]>

test: set test to pending due to bug

4e0b2ce

chore: use variable instead of calling node.parent_module_name again

4024a6f

ci: test against ruby 3.0 and 3.1

e0e8542

RenzoMinelli force-pushed the support_ruby_3.1 branch from f4562a1 to e0e8542 Compare February 10, 2023 00:07

build: upgrade minimun version of ruby to 2.5

0ce5785

pariser approved these changes Feb 10, 2023

View reviewed changes

pariser merged commit 762cd62 into airbnb:master Feb 10, 2023

pariser mentioned this pull request Feb 13, 2023

Upgrade to latest rubocop packages #178

Closed

pariser mentioned this pull request Sep 21, 2023

Ruby 3.1.3 #187

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support ruby 3.1 #189

Support ruby 3.1 #189

RenzoMinelli commented Feb 1, 2023

RenzoMinelli Feb 1, 2023

pariser Feb 8, 2023

RenzoMinelli Feb 1, 2023

pariser Feb 8, 2023

RenzoMinelli Feb 8, 2023

pariser left a comment

pariser Feb 8, 2023

RenzoMinelli Feb 8, 2023

pariser Feb 8, 2023

pariser Feb 8, 2023

pariser Feb 8, 2023

pariser Feb 8, 2023

RenzoMinelli Feb 9, 2023 •

edited

Loading

pariser commented Feb 9, 2023

RenzoMinelli commented Feb 10, 2023

pariser commented Feb 10, 2023

RenzoMinelli commented Feb 10, 2023

pariser commented Feb 10, 2023

pariser left a comment

RenzoMinelli commented Feb 10, 2023

Support ruby 3.1 #189

Support ruby 3.1 #189

Conversation

RenzoMinelli commented Feb 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pariser left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RenzoMinelli Feb 9, 2023 • edited Loading

Choose a reason for hiding this comment

pariser commented Feb 9, 2023

RenzoMinelli commented Feb 10, 2023

pariser commented Feb 10, 2023

RenzoMinelli commented Feb 10, 2023

pariser commented Feb 10, 2023

pariser left a comment

Choose a reason for hiding this comment

RenzoMinelli commented Feb 10, 2023

RenzoMinelli Feb 9, 2023 •

edited

Loading