Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove deprecated pyscopg v2 (pyscopg2) #532

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+478 −482
Open

Chore: Remove deprecated pyscopg v2 (pyscopg2) #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5877a9a
chore: remove pyscopg2
aaronsteers Nov 16, 2024
a8ea2a0
use v3 sqlalchemy url syntax
aaronsteers Nov 16, 2024
3fa7300
Merge branch 'main' into chore/remove-deprecated-pyscopg-v2
aaronsteers Nov 19, 2024
1597f53
re-remove psycopg v2
aaronsteers Nov 19, 2024
1de7cce
Auto-commit Updating dependencies
Nov 19, 2024
fe45f96
Merge branch 'main' into chore/remove-deprecated-pyscopg-v2
aaronsteers Dec 2, 2024
45a0c47
Auto-commit Updating dependencies
Dec 2, 2024
a7e9d73
create url string with sqlalchemy URL constructor
aaronsteers Dec 2, 2024
c8f5b1b
Merge branch 'main' into chore/remove-deprecated-pyscopg-v2
aaronsteers Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions airbyte/_processors/sql/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import functools

from overrides import overrides
from sqlalchemy import URL

from airbyte._util.name_normalizers import LowerCaseNormalizer
from airbyte._writers.jsonl import JsonlWriter
Expand All @@ -28,9 +29,15 @@ class PostgresConfig(SqlConfig):
@overrides
def get_sql_alchemy_url(self) -> SecretString:
"""Return the SQLAlchemy URL to use."""
return SecretString(
f"postgresql://{self.username}:{self.password}@{self.host}:{self.port}/{self.database}"
url = URL.create(
drivername="postgresql+psycopg",
username=self.username,
password=self.password,
host=self.host,
port=self.port, # defaults to 5432
database=self.database,
)
return SecretString(str(url))

@overrides
def get_database_name(self) -> str:
Expand Down
Loading
Loading