fix: avoid helm conflict with local directory #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuchanan-airbyte
changed the title
abuchanan-airbyte
force-pushed
the
abuch/helm-dir-conflict
branch
2 times, most recently
from
ea0988a to
3e574d5
Compare
abuchanan-airbyte
force-pushed
the
abuch/helm-dir-conflict
branch
from
3e574d5 to
257986b
Compare
colesnodgrass
approved these changes
Sep 3, 2024
internal/cmd/local/local/specs.go
Outdated
| @@ -39,7 +39,7 @@ func ingressRule(host string) networkingv1.IngressRule { | |||
| var pathType = networkingv1.PathType("Prefix") | |||
|
|
|||
| return networkingv1.IngressRule{ | |||
| Host: host, | |||
| // Host: host, | |||
There was a problem hiding this comment.
This looks like an accidental commit
There was a problem hiding this comment.
bah, thanks, fixed.
abuchanan-airbyte
force-pushed
the
abuch/helm-dir-conflict
branch
from
33ff5bc to
314b2a3
Compare
abuchanan-airbyte
force-pushed
the
abuch/helm-dir-conflict
branch
from
314b2a3 to
a1cdd8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm has an issue where it can confuse a local directory with a requested chart: helm/helm#7862
For example, if you have a local, empty directory path
./airbyte/airbyteand you request theairbyte/airbytechart, abctl + helm will fail withunable to install airbyte chart: unable to fetch chart airbyte/airbyte: Chart.yaml file is missingThis change avoids that problem (currently only for the
airbyte/airbytechart when requesting the latest version) by determining the full URL of the chart and using that, which causes Helm to avoid looking at local directories.I avoided handling the nginx chart and non-latest versions here for simplicity, but I could probably add support for those fairly easily.