chore: move Stripe webhook handling to a single endpoint with dedicat…

…ed signing secret (#14394)
airbytehq · Oct 17, 2024 · 3e8e204 · 3e8e204
1 parent a917da8
commit 3e8e204
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/airbyte-api/server-api/src/main/openapi/config.yaml b/airbyte-api/server-api/src/main/openapi/config.yaml
@@ -4607,13 +4607,13 @@ paths:
             application/json:
               schema:
                 $ref: "#/components/schemas/CustomerPortalRead"
-  /v1/billing/complete_checkout_session:
+  /v1/billing/handle_webhook:
     post:
-      summary: Complete a checkout session
+      summary: Handle an external billing event (ie a webhook from an external payment provider service)
       tags:
         - billing
         - cloud-only
-      operationId: completeCheckoutSession
+      operationId: handleWebhook
       requestBody:
         content:
           application/json:
@@ -4626,7 +4626,7 @@ paths:
           description: Invalid payload
         "401":
           description: Invalid signature
-      # This route is unsecured as it accepts webhook events from Stripe, which are validated by their signature.
+      # This route is unsecured as it accepts webhook events from an external service, which are validated by their signature.
       security: []
 
   /v1/billing/list_invoices:

diff --git a/airbyte-server/src/main/kotlin/io/airbyte/server/apis/controllers/BillingController.kt b/airbyte-server/src/main/kotlin/io/airbyte/server/apis/controllers/BillingController.kt
@@ -48,9 +48,9 @@ open class BillingController : BillingApi {
     @Body organizationIdRequestBody: OrganizationIdRequestBody,
   ): OrganizationBalanceRead = throw ApiNotImplementedInOssProblem()
 
-  @Post("/complete_checkout_session")
+  @Post("/handle_webhook")
   @ExecuteOn(AirbyteTaskExecutors.WEBHOOK)
-  override fun completeCheckoutSession(
+  override fun handleWebhook(
     @Body event: JsonNode,
   ): Unit = throw ApiNotImplementedInOssProblem()