Skip to content

Commit

Permalink
fix(helm): imagePullSecrets template in metrics subchart (#14102)
Browse files Browse the repository at this point in the history
Co-authored-by: emumba <[email protected]>
Co-authored-by: talha-naeem1 <[email protected]>
Co-authored-by: perangel <[email protected]>
Co-authored-by: perangel <[email protected]>
  • Loading branch information
5 people committed Sep 24, 2024
1 parent e99b92b commit 665da94
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions charts/airbyte-metrics/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ spec:
{{- end }}
spec:
serviceAccountName: {{ .Values.global.serviceAccountName }}
{{- if .Values.global.imagePullSecrets }}
{{- if .Values.global.imagePullSecrets }}
imagePullSecrets:
{{- range .Values.global.imagePullSecrets }}
{{- printf "- name: %s" .name | nindent 2 }}
{{- printf "- name: %s" .name | nindent 8 }}
{{- end }}
{{- end }}
{{- if .Values.nodeSelector }}
Expand Down
2 changes: 2 additions & 0 deletions charts/airbyte-metrics/values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@

global:
# imagePullSecrets:
# - name: ""
serviceAccountName: placeholderServiceAccount
deploymentMode: oss
extraContainers: []
Expand Down

0 comments on commit 665da94

Please sign in to comment.